Reverse 1:n relationships

[lutter]

This pull request reverse how 1:n associations are stored in Uniswap: rather than storing them as an array on the 'n' side, they are now stored as a scalar attribute on the '1' side. Doing it this way makes things much easier for the database when executing queries.

One downside is that changing which side is stored and which side is derived changes what filters are available - if that conflicts with how Uniswap needs to be queried, feel free to ignore any of this.

I did sync with this version of Uniswap on a test system successfully, but I don't know the ins and outs of the subgraph enough to be able to tell whether I broke some other functionality.

[davekaj]

The code looks good (other than adding the !). We need to ask @ianlapham if this change would effect their front end because of the filter changes.

Also, maybe we should announce it in discord? Maybe others use this subgraph?

[davekaj]

We can add a ! to this

[davekaj]

Merging this would close #28

[ianlapham]

This makes sense to me - if the performance would greatly improve it might be worth it to update our queries on our frotn-end to support the changes. Is there a way to deploy this to some other subgraph so I could test it first?

[davekaj]

I just deployed it, but I assume lutter already deployed it somewhere because it was instantly synced for me. You can see it here https://thegraph.com/explorer/subgraph/davekaj/uniswap

[lutter]

Yes, I had deployed it a while ago, and completely forgotten about it; it's also at https://thegraph.com/explorer/subgraph/lutter/uniswap-rels

[ianlapham]

I just tested this with our v1 info client - it actually seems to work with no changes required to our queries. If this helps us sync faster through grafting I'm ok to merge this in. @davekaj @lutter

[davekaj]

great, will merge now