Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change the interfaces and struct definitions for dips #597

Merged
merged 2 commits into from
Feb 6, 2025
Merged

refactor: change the interfaces and struct definitions for dips #597

merged 2 commits into from
Feb 6, 2025
+1,214 −455

Conversation

pcarranzav
Copy link
Member

@pcarranzav pcarranzav commented Jan 31, 2025 •
edited
Loading

  • Changed the database table for dips to indexing_agreements
  • Changed some field names for consistency (camelCase)
  • Added pricePerEntity to dips vouchers
  • Changed the types used for network names and addresses
  • Added a current allocation id to indexing agreements (will be used by the indexer agent)

@coveralls
Copy link

coveralls commented Feb 3, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13179235788

Details

  • 247 of 312 (79.17%) changed or added relevant lines in 5 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.8%) to 78.877%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/service/src/database/dips.rs 57 58 98.28%
crates/dips/src/server.rs 0 16 0.0%
crates/dips/src/lib.rs 159 183 86.89%
crates/dips/src/proto/graphprotocol.gateway.dips.rs 0 24 0.0%
Files with Coverage Reduction New Missed Lines %
crates/dips/src/lib.rs 1 91.65%
crates/dips/src/server.rs 2 0.0%
Totals Coverage Status
Change from base Build 13164077066: 0.8%
Covered Lines: 7360
Relevant Lines: 9331
💛 - Coveralls

@pcarranzav pcarranzav requested review from mangas and LNSD February 3, 2025 14:38
@pcarranzav pcarranzav marked this pull request as ready for review February 3, 2025 14:38
@pcarranzav pcarranzav marked this pull request as draft February 3, 2025 18:53
@pcarranzav
Copy link
Member Author

Back to Draft as I'm adding a few more changes

@pcarranzav pcarranzav changed the title fix: change some names and add necessary fields to indexing agreements fix: change the interfaces and struct definitions for dips Feb 6, 2025
@pcarranzav pcarranzav marked this pull request as ready for review February 6, 2025 12:19
gusinacio
gusinacio approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gusinacio gusinacio changed the title fix: change the interfaces and struct definitions for dips refactor: change the interfaces and struct definitions for dips Feb 6, 2025
@mangas mangas merged commit 93833c9 into main Feb 6, 2025
10 checks passed
@mangas mangas deleted the pcv/dips-details branch February 6, 2025 16:06
LNSD
LNSD reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LNSD LNSD LNSD left review comments

@suchapalaver suchapalaver suchapalaver left review comments

@mangas mangas mangas approved these changes

@gusinacio gusinacio gusinacio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pcarranzav @coveralls @mangas @LNSD @gusinacio @suchapalaver