-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: aggregate ravs depending on allocation type #596
Conversation
Pull Request Test Coverage Report for Build 13145110259Details
💛 - Coveralls |
70c9a9a
to
35046f6
Compare
e208f23
to
355b891
Compare
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
47ed6ec
to
d1c87d4
Compare
Signed-off-by: Gustavo Inacio <[email protected]>
03cda08
to
21a37af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gusinacio Thanks so much this looks great and thank you for all the amazing knowledge-sharing in the docs and comments! Just a couple of small things I caught and then good to go 🚀 !
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🙏
NetworkVersion
trait used to define what kind of allocation we are handling.NetworkVersion
AllocationId
enum.TODO for future PRs:
Note
tap-agent is not well organized and we have a few files with 1k+ lines. Suggestions on how to organize are accepted.