Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: store horizon receipts #595

Merged
merged 4 commits into from
Feb 3, 2025
Merged

Conversation

gusinacio
Copy link
Member

No description provided.

Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio gusinacio force-pushed the gustavo/store-tap-horizon-receipts branch from f9fb070 to 7518aa7 Compare January 31, 2025 13:13
Copy link
Contributor

github-actions bot commented Jan 31, 2025

Pull Request Test Coverage Report for Build 13118832745

Details

  • 99 of 146 (67.81%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 78.616%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/service/src/tap/receipt_store.rs 99 146 67.81%
Files with Coverage Reduction New Missed Lines %
crates/service/src/tap/receipt_store.rs 1 76.85%
Totals Coverage Status
Change from base Build 13109844496: -0.2%
Covered Lines: 7110
Relevant Lines: 9044

💛 - Coveralls

Copy link
Contributor

@suchapalaver suchapalaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gusinacio just one suggestion to make process_db_receipts and this looks great 👍

crates/service/src/tap/receipt_store.rs Outdated Show resolved Hide resolved
crates/service/src/tap/receipt_store.rs Outdated Show resolved Hide resolved
@gusinacio gusinacio merged commit 3c240c0 into main Feb 3, 2025
10 checks passed
@gusinacio gusinacio deleted the gustavo/store-tap-horizon-receipts branch February 3, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants