Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] create_recursive_abstract: when creating items via import of th… #182

Merged

Conversation

legalsylvain
Copy link
Member

…e model, allow to create dynamically parents

…e model, allow to create dynamically parents
@legalsylvain legalsylvain force-pushed the 16.0-create_recursive-allow-import branch from b052bb6 to ac8c334 Compare December 20, 2024 13:47
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.31%. Comparing base (5697159) to head (ac8c334).
Report is 3 commits behind head on 16.0.

Files with missing lines Patch % Lines
...te_recursive_abstract/models/base_import_import.py 66.66% 2 Missing ⚠️
...ecursive_abstract/models/create_recursive_mixin.py 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             16.0     #182      +/-   ##
==========================================
- Coverage   94.69%   94.31%   -0.38%     
==========================================
  Files          31       32       +1     
  Lines         245      264      +19     
  Branches       15       17       +2     
==========================================
+ Hits          232      249      +17     
- Misses         10       12       +2     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legalsylvain
Copy link
Member Author

Mep du 20/12/2024

/ocabot merge major

@github-grap-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-182-by-legalsylvain-bump-major, awaiting test results.

@github-grap-bot github-grap-bot merged commit 3839a32 into grap:16.0 Jan 6, 2025
2 of 4 checks passed
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at e8cf090. Thanks a lot for contributing to grap. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants