Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Remove false sale order line on x2m on mrp sale grouped #349

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

quentinDupont
Copy link
Member

@quentinDupont quentinDupont commented Jan 12, 2024

Ticket 1073

Avant
image

Après

image

Et ticket 1075 pour bug sur assistant de prod si note ou section dans sale order

@quentinDupont
Copy link
Member Author

j'ai poussé sur grap car je l'avais en tête mais bon pas besoin là en fait 🤷 :)

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7bbe5af) 78.51% compared to head (8c6debd) 78.51%.
Report is 3 commits behind head on 12.0.

Files Patch % Lines
...rp_sale_grouped/wizard/x2m_matrix_grouped_sales.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             12.0     #349   +/-   ##
=======================================
  Coverage   78.51%   78.51%           
=======================================
  Files         221      221           
  Lines        2486     2486           
  Branches      440      441    +1     
=======================================
  Hits         1952     1952           
  Misses        502      502           
  Partials       32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legalsylvain
Copy link
Member

j'ai poussé sur grap car je l'avais en tête mais bon pas besoin là en fait 🤷 :)

c'est pas un soucis que tu pousses sur GRAP !

@legalsylvain
Copy link
Member

MeP du 28/01/2024

/ocabot merge patch

@github-grap-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-349-by-legalsylvain-bump-patch, awaiting test results.

@github-grap-bot github-grap-bot merged commit 67975c7 into 12.0 Jan 30, 2024
3 of 4 checks passed
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at ac2a953. Thanks a lot for contributing to grap. ❤️

@github-grap-bot github-grap-bot deleted the 12.0-1073-mrp_sale_grouped-remove-false-on-x2m branch January 30, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants