-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix image paper feed #47
base: main
Are you sure you want to change the base?
Conversation
Important note: This change breaks 5 tests. So please double check if all of these model outputs should be changed, or if previous implementation for some of them was correct. Changes output of:
It this is correct, I will update all these files for all tests passing (by additional commit). Should be done before PR approval. In other cases, further discussion is needed. :-) |
Thanks for this pull request fix, i will test on printer this new binaries, but its problably that this image printing will get spacing between two lines for model MP-4200 TH, i will put the results here |
Thanks for the answer @mazinsw. I am interested in testing your model. There is the interesting message on page 34:
So for a smaller image, it looks like the |
Dear @samueldurantes. |
@samueldurantes or @grandchef - Should I close this PR? It is already reviewed, and approved, but nobody merged it. |
@mazinsw can I merge this PR? |
I have not tested yet (sorry i forgot), i remember that this line break and create a horizontal spacing between image lines on some of these affected printers, if you can test and merge, do it, because i'am out of this repo/company |
Fixes issue #46.