Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image paper feed #47

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix image paper feed #47

wants to merge 2 commits into from

Conversation

ma-zal
Copy link

@ma-zal ma-zal commented Mar 31, 2023

Fixes issue #46.

@ma-zal ma-zal changed the title Fixed image paper feed Fix image paper feed Mar 31, 2023
@ma-zal
Copy link
Author

ma-zal commented Mar 31, 2023

Important note: This change breaks 5 tests. So please double check if all of these model outputs should be changed, or if previous implementation for some of them was correct.

Changes output of:

  • __tests__/resources/cmp-20_qrcode.bin
  • __tests__/resources/dr800_draw_buffer.bin
  • __tests__/resources/mp-4200_th_draw_buffer.bin
  • __tests__/resources/mp-4200_th_draw_file.bin
  • __tests__/resources/printid_qrcode.bin

It this is correct, I will update all these files for all tests passing (by additional commit). Should be done before PR approval. In other cases, further discussion is needed. :-)

@mazinsw
Copy link
Contributor

mazinsw commented Apr 1, 2023

Thanks for this pull request fix, i will test on printer this new binaries, but its problably that this image printing will get spacing between two lines for model MP-4200 TH, i will put the results here

@ma-zal
Copy link
Author

ma-zal commented Apr 1, 2023

Thanks for the answer @mazinsw. I am interested in testing your model.
I found the specifications of your MP-4200 TH.

There is the interesting message on page 34:

A full print line with ‘N’ columns will need N*3 bytes. If the image to print has less than ‘N’ graphic
columns, a LF command must be sent to perform line printing. Text and graphic may be mixed
in the same line.

So for a smaller image, it looks like the 0x0A is correct. But for sure we can also test if a behavior is the same on images with the exact maximum width.

@ma-zal
Copy link
Author

ma-zal commented Oct 24, 2023

Dear @samueldurantes.
I just rebased my PR to help to merge. Please merge this PR ... or else close without merging if not wanted. Thanks.

@ma-zal
Copy link
Author

ma-zal commented Jan 21, 2025

@samueldurantes or @grandchef - Should I close this PR? It is already reviewed, and approved, but nobody merged it.

@samueldurantes
Copy link
Collaborator

@mazinsw can I merge this PR?

@mazinsw
Copy link
Contributor

mazinsw commented Jan 21, 2025

I have not tested yet (sorry i forgot), i remember that this line break and create a horizontal spacing between image lines on some of these affected printers, if you can test and merge, do it, because i'am out of this repo/company

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants