Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Improve errors in the loader #2634

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Conversation

mkow
Copy link
Member

@mkow mkow commented Aug 8, 2021

Description of the changes

Should help in cases like #2632 and #2633.

How to test this PR?

Try to run invalid/non-existent executables and check the errors printed.


This change is Reviewable

dimakuv
dimakuv previously approved these changes Aug 9, 2021
Copy link

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)

boryspoplawski
boryspoplawski previously approved these changes Aug 9, 2021
Copy link
Contributor

@boryspoplawski boryspoplawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mkow mkow dismissed stale reviews from boryspoplawski and dimakuv via b9e1517 August 9, 2021 17:01
@mkow mkow force-pushed the mkow/better-errors-in-loader branch from a479f8b to b9e1517 Compare August 9, 2021 17:01
Copy link
Contributor

@boryspoplawski boryspoplawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL)

Copy link

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dimakuv dimakuv merged commit b9e1517 into master Aug 9, 2021
@dimakuv dimakuv deleted the mkow/better-errors-in-loader branch August 9, 2021 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants