chore(dataobj): deduplicate decoder code across bucket and io.ReadSeeker #15945
+337
−1,196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
commented
Jan 24, 2025
| github.com/dustin/go-humanize v1.0.1 | ||
| github.com/grafana/loki/v3 v3.3.2 | ||
| ) | ||
| require github.com/grafana/loki/v3 v3.3.2 |
There was a problem hiding this comment.
@benclive Go told me I needed to run go mod tidy, let me know if anything here seems off
rfratto
commented
Jan 24, 2025
| ReadRange(ctx context.Context, offset int64, length int64) (io.ReadCloser, error) | ||
| } | ||
|
|
||
| type rangeDecoder struct { |
There was a problem hiding this comment.
This is more or less a copy/paste from the old bucket decoder but it uses rangeReader instead.
A previous comment identified that the code for BucketDecoder and ReadSeekerDecoder were extremely similar, and that they could be deduplicated by introducing some kind of "range reader" interface. This commit inroduces such an interface, which maps perfectly to bucket decoding. Implementations of the interface must be able to tolerate concurrent instance of readers, which io.ReadSeeker does not. To tolerate this while still allowing to decode data objects that are either in-memory or backed by a file, ReadSeekerDecoder has been updated to ReaderAtDecoder.
rfratto
force-pushed
the
dataobj-dedupe-decoders
branch
from
edc9d87 to
cf745b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous comment identified that the code for BucketDecoder and ReadSeekerDecoder were extremely similar, and that they could be deduplicated by introducing some kind of "range reader" interface.
This commit introduces such an interface, which maps perfectly to bucket decoding. Implementations of the interface must be able to tolerate concurrent instance of readers, which io.ReadSeeker does not. To tolerate this while still allowing to decode data objects that are either in-memory or backed by a file, ReadSeekerDecoder has been updated to ReaderAtDecoder and accepts a size argument to note how large the object is.