[DEFUNCT] Data Source API: Add support for Amazon Redshift and Clickhouse #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
commented
Jan 10, 2024
Comment on lines
+308
to
+311
| { | ||
| "name": "maxDataPoints", | ||
| "default": 1441, | ||
| }, |
There was a problem hiding this comment.
Hi again. Is this a sane default value? Or should this spot be adjusted in one way or another before merging?
/cc @peekjef72
Comment on lines
+299
to
+303
| { | ||
| "name": "format", | ||
| "default": 0, | ||
| "choices": [0, 1], | ||
| }, |
There was a problem hiding this comment.
Should the choice of response format be obtained from the user in one way or another? Is it fine to leave for a subsequent iteration?
amotl
changed the title
amotl
changed the title
|
Closing in favor of GH-166, in order to bring in the improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Add query support for Amazon Redshift and Clickhouse, by @lpfann / @mysuperai. Thanks!