Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add_annotation to also accept dashboard_uid argument #144

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

amotl
Copy link
Contributor

@amotl amotl commented Jan 8, 2024

About

This patch intends to fix GH-140 reported by @IBUMBLEBEE. Thanks.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca42f53) 94.43% compared to head (e3d2442) 94.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   94.43%   94.44%   +0.01%     
==========================================
  Files          26       26              
  Lines        1707     1711       +4     
==========================================
+ Hits         1612     1616       +4     
  Misses         95       95              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl amotl marked this pull request as ready for review January 8, 2024 22:56
@amotl amotl merged commit 162f647 into main Jan 8, 2024
7 checks passed
@amotl amotl deleted the amo/fix-annotations branch January 8, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New version of Grafana API create-annotation adds dashboardUID field
1 participant