Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add init.d setup example #69

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add init.d setup example #69

wants to merge 3 commits into from

Conversation

gabrielfeo
Copy link
Member

@gabrielfeo gabrielfeo commented Jan 20, 2025

Suggest the possibility of applying injecting the Develocity init script for all builds by moving it to init.d.

Manually tested on a GitLab repository:

Signed-off-by: Gabriel Féo <[email protected]>
README.md Outdated Show resolved Hide resolved
Copy link
Member

@alextu alextu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should work but have you been able to test the documented snippet (manually) ?

@gabrielfeo
Copy link
Member Author

@alextu, could you review again, please? I added a mkdir in case the Gradle user home doesn't exist yet and changed mv to cp so that the variable DEVELOCITY_INIT_SCRIPT_PATH keeps making sense.

It should work but have you been able to test the documented snippet (manually) ?

I had not, wanted to hear if it made sense to you first. I updated the description with links to a test.

@gabrielfeo gabrielfeo marked this pull request as ready for review January 30, 2025 18:26
@gabrielfeo gabrielfeo requested a review from alextu January 30, 2025 18:26
@gabrielfeo gabrielfeo marked this pull request as draft January 30, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants