This repository has been archived by the owner on Nov 28, 2024. It is now read-only.
fix: update chatbox with mention fix #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
codeofmochi
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
Changes LGTM but what is the mention fix? I couldn't parse it from the code nor the related issue, does it come from a dependency? @spaenleh
|
@dialexo Yes it is the fix from this issue about the mention regex not accepting certain syntaxes So in this PR I update the version of the chatbox to include this fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates dependencies and adds the new mentions fix from chatbox.
closes #177