-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: control show less/more button at public profile bio #486
Conversation
I'm not really convinced by the line-height-ref method. Plus there're some mismatching problem here:
I think a low-level component should include the button that expand button + content with fading (mainly the issue I've linked). Maybe it should be adaptable to use or not interweave. What do you think @spaenleh ? So this PR would handle both issues. |
24fa1cd
to
f25bfb3
Compare
@pyphilia @LinaYahya I agree. Also if the computation actually just returns the line height, why not simply use the
Then you compose them together to get the desired result |
03ac9f0
to
33ff370
Compare
33ff370
to
b1cfea1
Compare
Quality Gate passedIssues Measures |
closes #480