Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use graasp button #305

Merged
merged 3 commits into from
Mar 31, 2022
Merged

refactor: use graasp button #305

merged 3 commits into from
Mar 31, 2022

Conversation

pyphilia
Copy link
Contributor

This PR updates some properties in TextEditor / DocumentItem corresponding to the changes in graasp-ui.
It also removes all buttons to use the Button in @graasp/ui.

close #304

@pyphilia pyphilia requested a review from alvrba March 16, 2022 17:34
@pyphilia pyphilia self-assigned this Mar 16, 2022
@alvrba
Copy link
Contributor

alvrba commented Mar 17, 2022

I have tested graasp-compose and graasp-ui, and the buttons are working fine. I have two doubts:

  • Do we want to change all the buttons to the graasp-ui button? For example, in the NewButtonItem component, we are still using the material-ui button directly.
  • Graasp-compose is crashing when creating a new item of type File or Import APP. I see the uppy module has been updated to a recent version, and I have tried with the previous one, but it is still giving me the error. I do not know if maybe it is my local problem because I need something else (but it works fine with the Graasp compose in main). Can you check if it is working for you?

@pyphilia
Copy link
Contributor Author

@alvrba Indeed you're right, the app is crashing (I did it quite quickly yesterday). The problems comes from both react-scripts v5 and uppy facebook/create-react-app#12021 I've downgraded react-scripts. Though the whole idea was to remove the security alerts but I guess we will keep them for the time being.

And we want to replace all the buttons yes!

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@pyphilia pyphilia merged commit 3deca6c into master Mar 31, 2022
@pyphilia pyphilia deleted the 304/graaspButton branch March 31, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Graasp Button from graasp-ui
2 participants