Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: platform switch in analytics #596

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Jan 13, 2025

In this PR I add the platform switch back to analytics to allow switching to the player or builder view.

The analytics and library icons are disabled.

@spaenleh spaenleh requested a review from pyphilia January 13, 2025 13:25
@spaenleh spaenleh self-assigned this Jan 13, 2025
@spaenleh spaenleh force-pushed the fix-platform-switch-analytics branch from 6724868 to f3bbb0b Compare January 13, 2025 13:26
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I had a question, we can discuss tomorrow 🔬

src/modules/analytics/PageWrapper.tsx Outdated Show resolved Hide resolved
@spaenleh spaenleh force-pushed the fix-platform-switch-analytics branch 2 times, most recently from 9378885 to 7f8dfe5 Compare January 14, 2025 09:30
@spaenleh spaenleh enabled auto-merge January 14, 2025 09:30
@spaenleh spaenleh force-pushed the fix-platform-switch-analytics branch from 7f8dfe5 to dcd38f9 Compare January 14, 2025 09:55
@spaenleh spaenleh added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit c4e2d61 Jan 14, 2025
5 checks passed
@spaenleh spaenleh deleted the fix-platform-switch-analytics branch January 14, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants