Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build library profile page (UI) #41

Merged
merged 13 commits into from
Dec 21, 2023
Merged

feat: build library profile page (UI) #41

merged 13 commits into from
Dec 21, 2023

Conversation

LinaYahya
Copy link
Contributor

@LinaYahya LinaYahya commented Nov 6, 2023

closes #30
image

Validation

image

@LinaYahya LinaYahya marked this pull request as ready for review November 9, 2023 13:31
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to apply the same changes that is use PublicProfile. Plus some concerns about modularisation and fetching. Let me know if you have questions! 🌈

src/components/main/LibraryProfileScreen.tsx Outdated Show resolved Hide resolved
src/components/main/LibraryProfileScreen.tsx Outdated Show resolved Hide resolved
src/config/notifier.ts Outdated Show resolved Hide resolved
src/config/paths.ts Outdated Show resolved Hide resolved
src/langs/en.json Outdated Show resolved Hide resolved
src/components/main/LibraryProfileScreen.tsx Outdated Show resolved Hide resolved
src/components/main/LibraryProfileScreen.tsx Outdated Show resolved Hide resolved
src/components/main/LibraryProfileScreen.tsx Outdated Show resolved Hide resolved
src/components/main/LibraryProfileScreen.tsx Outdated Show resolved Hide resolved
src/components/main/LibraryProfileScreen.tsx Outdated Show resolved Hide resolved
@LinaYahya LinaYahya requested a review from pyphilia November 27, 2023 09:53
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍂

package.json Outdated Show resolved Hide resolved
src/components/main/PublicProfileScreen.tsx Outdated Show resolved Hide resolved
src/config/notifier.ts Outdated Show resolved Hide resolved
@LinaYahya LinaYahya merged commit c51d8f4 into main Dec 21, 2023
2 checks passed
@LinaYahya LinaYahya deleted the 30-profile-bio branch December 21, 2023 08:34
@LinaYahya LinaYahya self-assigned this Dec 21, 2023
spaenleh pushed a commit that referenced this pull request Jan 16, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a public description that can be shown in the library profile
2 participants