fix: update ts config

.eslintrc.json

@@ -21,6 +21,11 @@
   },
   "parser": "@typescript-eslint/parser",
   "parserOptions": {
+    "project": [
+      "./tsconfig.app.json",
+      "./tsconfig.node.json",
+      "./cypress/tsconfig.json"
+    ],
     "ecmaFeatures": {
       "jsx": true
     },
@@ -60,6 +65,7 @@
       }
     ],
     "import/no-named-as-default": "off",
+    "import/extensions": "off",
     "react/static-property-placement": [
       "error",
       "property assignment",
@@ -79,16 +85,6 @@
         "allow": ["error"]
       }
     ],
-    "import/extensions": [
-      "error",
-      "ignorePackages",
-      {
-        "js": "never",
-        "jsx": "never",
-        "ts": "never",
-        "tsx": "never"
-      }
-    ],
     "react/prop-types": "off",
     "react/require-default-props": "off",
     // eslint rule reports false error
@@ -109,7 +105,8 @@
         "devDependencies": true
       }
     ],
-    "import/prefer-default-export": "off"
+    "import/prefer-default-export": "off",
+    "import/no-unresolved": "off"
   },
   "overrides": [
     {

.vscode/settings.json

@@ -1,3 +1,4 @@
 {
-  "files.trimTrailingWhitespace": true
+  "files.trimTrailingWhitespace": true,
+  "eslint.useFlatConfig": false
 }

cypress/e2e/homePage.cy.ts

@@ -3,7 +3,7 @@ import { HttpMethod, formatDate } from '@graasp/sdk';
 
 import { StatusCodes } from 'http-status-codes';
 
-import i18n from '@/config/i18n';
+import i18n from '../../src/config/i18n';
 import {
   AVATAR_UPLOAD_ICON_ID,
   AVATAR_UPLOAD_INPUT_ID,
@@ -14,8 +14,7 @@ import {
   MEMBER_AVATAR_IMAGE_ID,
   MEMBER_CREATED_AT_ID,
   MEMBER_USERNAME_DISPLAY_ID,
-} from '@/config/selectors';
-
+} from '../../src/config/selectors';
 import { BOB, MEMBER_WITH_AVATAR } from '../fixtures/members';
 import {
   AVATAR_LINK,
@@ -33,7 +32,6 @@ class TestHelper {
 
   constructor(args: TestHelperInput) {
     this.currentMember = JSON.parse(JSON.stringify(args.currentMember));
-    this.setupServer();
   }
 
   setupServer() {
@@ -76,10 +74,10 @@ class TestHelper {
 }
 
 describe('Upload Avatar', () => {
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   let helpers: TestHelper;
   beforeEach(() => {
     helpers = new TestHelper({ currentMember: BOB });
+    helpers.setupServer();
     cy.visit('/');
   });
 

cypress/e2e/notFoundPage.cy.ts

@@ -2,8 +2,7 @@ import {
   GO_TO_HOME_LINK_ID,
   NOT_FOUND_MESSAGE_ID,
   NOT_FOUND_TEXT_ID,
-} from '@/config/selectors';
-
+} from '../../src/config/selectors';
 import { BOB } from '../fixtures/members';
 
 describe('404 Page Test', () => {

cypress/e2e/profile/password.cy.ts

@@ -1,7 +1,7 @@
 import { FAILURE_MESSAGES, namespaces } from '@graasp/translations';
 
-import i18n, { ACCOUNT_NAMESPACE } from '@/config/i18n';
-import { PROFILE_PATH } from '@/config/paths';
+import i18n, { ACCOUNT_NAMESPACE } from '../../../src/config/i18n';
+import { PROFILE_PATH } from '../../../src/config/paths';
 import {
   PASSWORD_CREATE_CONTAINER_ID,
   PASSWORD_DISPLAY_CONTAINER_ID,
@@ -11,8 +11,7 @@ import {
   PASSWORD_INPUT_CURRENT_PASSWORD_ID,
   PASSWORD_INPUT_NEW_PASSWORD_ID,
   PASSWORD_SAVE_BUTTON_ID,
-} from '@/config/selectors';
-
+} from '../../../src/config/selectors';
 import { ACCOUNT } from '../../../src/langs/constants';
 import { BOB } from '../../fixtures/members';
 

cypress/e2e/profile/personalInformation.cy.ts

@@ -1,5 +1,4 @@
-import { PROFILE_PATH } from 'config/paths';
-
+import { PROFILE_PATH } from '../../../src/config/paths';
 import {
   PERSONAL_INFO_CANCEL_BUTTON_ID,
   PERSONAL_INFO_DISPLAY_CONTAINER_ID,
@@ -9,8 +8,7 @@ import {
   PERSONAL_INFO_INPUT_EMAIL_ID,
   PERSONAL_INFO_SAVE_BUTTON_ID,
   PERSONAL_INFO_USERNAME_DISPLAY_ID,
-} from '@/config/selectors';
-
+} from '../../../src/config/selectors';
 import { BOB, MEMBERS } from '../../fixtures/members';
 
 const changeUsername = (newUserName: string) => {

cypress/e2e/profile/publicProfile.cy.ts

@@ -1,4 +1,4 @@
-import { PROFILE_PATH } from '@/config/paths';
+import { PROFILE_PATH } from '../../../src/config/paths';
 import {
   PUBLIC_PROFILE_BIO_ID,
   PUBLIC_PROFILE_EDIT_BUTTON_ID,
@@ -9,8 +9,7 @@ import {
   PUBLIC_PROFILE_SAVE_BUTTON_ID,
   PUBLIC_PROFILE_TWITTER_HREF_ID,
   PUBLIC_PROFILE_TWITTER_ID,
-} from '@/config/selectors';
-
+} from '../../../src/config/selectors';
 import {
   BOB,
   MEMBER_EMPTY_PUBLIC_PROFILE,

cypress/e2e/settings/deleteMember.cy.ts

@@ -1,13 +1,12 @@
-import { SETTINGS_PATH } from '@/config/paths';
+import { SETTINGS_PATH } from '../../../src/config/paths';
 import {
   DELETE_MEMBER_BUTTON_ID,
   DELETE_MEMBER_DIALOG_CONFIRMATION_BUTTON_ID,
   DELETE_MEMBER_DIALOG_CONFIRMATION_FIELD_ID,
   DELETE_MEMBER_DIALOG_TITLE_ID,
   DELETE_MEMBER_SECTION_ID,
   LOGIN_REQUIRED_TEXT_ID,
-} from '@/config/selectors';
-
+} from '../../../src/config/selectors';
 import { CURRENT_MEMBER } from '../../fixtures/members';
 
 describe('Current Member', () => {

cypress/e2e/settings/exportData.cy.ts

@@ -1,6 +1,5 @@
-import { SETTINGS_PATH } from '@/config/paths';
-import { EXPORT_DATA_BUTTON_ID } from '@/config/selectors';
-
+import { SETTINGS_PATH } from '../../../src/config/paths';
+import { EXPORT_DATA_BUTTON_ID } from '../../../src/config/selectors';
 import { CURRENT_MEMBER } from '../../fixtures/members';
 
 describe('Check exporting data', () => {

cypress/e2e/settings/preferences.cy.ts

@@ -1,7 +1,7 @@
 import { EmailFrequency } from '@graasp/sdk';
 import { langs } from '@graasp/translations';
 
-import { SETTINGS_PATH } from '@/config/paths';
+import { SETTINGS_PATH } from '../../../src/config/paths';
 import {
   PREFERENCES_ANALYTICS_SWITCH_ID,
   PREFERENCES_CANCEL_BUTTON_ID,
@@ -11,8 +11,7 @@ import {
   PREFERENCES_LANGUAGE_DISPLAY_ID,
   PREFERENCES_LANGUAGE_SWITCH_ID,
   PREFERENCES_SAVE_BUTTON_ID,
-} from '@/config/selectors';
-
+} from '../../../src/config/selectors';
 import { BOB, CURRENT_MEMBER } from '../../fixtures/members';
 
 describe('Display preferences', () => {

cypress/e2e/storage.cy.ts

@@ -1,16 +1,15 @@
 import { formatDate, formatFileSize } from '@graasp/sdk';
 
-import i18n from '@/config/i18n';
-import { STORAGE_PATH } from '@/config/paths';
+import i18n from '../../src/config/i18n';
+import { STORAGE_PATH } from '../../src/config/paths';
 import {
   MEMBER_STORAGE_FILE_NAME_ID,
   MEMBER_STORAGE_FILE_SIZE_ID,
   MEMBER_STORAGE_FILE_UPDATED_AT_ID,
   MEMBER_STORAGE_PARENT_FOLDER_ID,
   STORAGE_BAR_LABEL_ID,
   getCellId,
-} from '@/config/selectors';
-
+} from '../../src/config/selectors';
 import {
   CURRENT_MEMBER,
   MEMBER_STORAGE_ITEM_RESPONSE,

cypress/e2e/validateEmailPage.cy.ts

@@ -2,14 +2,13 @@ import { HttpMethod } from '@graasp/sdk';
 
 import { StatusCodes } from 'http-status-codes';
 
-import { EMAIL_CHANGE_VALIDATION_PATH } from '@/config/paths';
+import { EMAIL_CHANGE_VALIDATION_PATH } from '../../src/config/paths';
 import {
   EMAIL_VALIDATION_BUTTON_ID,
   EMAIL_VALIDATION_CONFLICT_MESSAGE_ID,
   EMAIL_VALIDATION_SUCCESS_MESSAGE_ID,
   EMAIL_VALIDATION_UNAUTHORIZED_MESSAGE_ID,
-} from '@/config/selectors';
-
+} from '../../src/config/selectors';
 import { CURRENT_MEMBER } from '../fixtures/members';
 
 const API_HOST = Cypress.env('VITE_GRAASP_API_HOST');

cypress/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../tsconfig.json",
+  "extends": "../tsconfig.app.json",
   "compilerOptions": {
     "target": "es5",
     "lib": ["es5", "dom", "ES2021.String"],
@@ -8,6 +8,6 @@
     "strict": true,
     "sourceMap": false
   },
-  "include": ["**/*.ts"],
+  "include": ["**/*.ts", "../cypress.config.ts"],
   "exclude": ["coverage", ".nyc_output"]
 }

package.json

@@ -57,7 +57,7 @@
     "pre-commit": "pnpm prettier:check && pnpm lint && pnpm type-check",
     "prettier:check": "prettier --check src/**/*.{ts,tsx}",
     "prettier:write": "prettier --write src/**/*.{ts,tsx}",
-    "type-check": "tsc --noEmit",
+    "type-check": "tsc --noEmit -p tsconfig.app.json",
     "check": "pnpm prettier:check && pnpm lint && pnpm type-check",
     "hooks:install": "husky",
     "preinstall": "npx only-allow pnpm",

src/modules/settings/ExportData.tsx

@@ -1,4 +1,4 @@
-import React, { useState } from 'react';
+import { useState } from 'react';
 
 import { Button, Stack, Typography } from '@mui/material';
 

tsconfig.app.json

@@ -0,0 +1,25 @@
+{
+  "compilerOptions": {
+    "target": "ES2020",
+    "useDefineForClassFields": true,
+    "lib": ["ES2020", "DOM", "DOM.Iterable"],
+    "module": "ESNext",
+    "skipLibCheck": true,
+    /* Bundler mode */
+    "moduleResolution": "bundler",
+    "allowImportingTsExtensions": true,
+    "isolatedModules": true,
+    "moduleDetection": "force",
+    "noEmit": true,
+    "jsx": "react-jsx",
+    /* Linting */
+    "strict": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "noFallthroughCasesInSwitch": true,
+    "paths": {
+      "@/*": ["./src/*"]
+    }
+  },
+  "include": ["src"]
+}

tsconfig.json

@@ -1,36 +1,15 @@
 {
-  "compilerOptions": {
-    "target": "ESNext",
-    "useDefineForClassFields": true,
-    "lib": ["DOM", "DOM.Iterable", "ESNext", "ES2021.String"],
-    "allowJs": true, // todo: change to false once Uppy is moved to ts
-    "module": "ESNext",
-    "skipLibCheck": true,
-
-    "esModuleInterop": true,
-    "allowSyntheticDefaultImports": true,
-    "strict": true,
-
-    "moduleResolution": "Bundler",
-    "allowImportingTsExtensions": true,
-    "resolveJsonModule": true,
-    "isolatedModules": true,
-    "noEmit": true,
-    "jsx": "react-jsx",
-
-    "strictNullChecks": true,
-    "forceConsistentCasingInFileNames": true,
-
-    "types": ["vite/client", "cypress"],
-    "baseUrl": "./src",
-    "paths": {
-      "@/*": ["./*"]
-    }
-  },
-  "include": ["src"],
+  "files": [],
   "references": [
+    {
+      "path": "./tsconfig.app.json"
+    },
     {
       "path": "./tsconfig.node.json"
     }
-  ]
+  ],
+  "compilerOptions": {
+    // this is needed for cypress to compile to ESM ... Should be removed when not using cypress anymore
+    "module": "ESNext"
+  }
 }

tsconfig.node.json

@@ -1,10 +1,20 @@
 {
   "compilerOptions": {
-    "composite": true,
+    "target": "ES2022",
+    "lib": ["ES2023"],
     "module": "ESNext",
-    "jsx": "react-jsx",
-    "moduleResolution": "Node",
-    "allowSyntheticDefaultImports": true
+    "skipLibCheck": true,
+    /* Bundler mode */
+    "moduleResolution": "bundler",
+    "allowImportingTsExtensions": true,
+    "isolatedModules": true,
+    "moduleDetection": "force",
+    "noEmit": true,
+    /* Linting */
+    "strict": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "noFallthroughCasesInSwitch": true
   },
-  "include": ["vite.config.ts"]
+  "include": ["vite-env.d.ts", "vite.config.ts"]
 }