fix: avatar upload size error #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spaenleh I started the move to the UI, but as I thought it wasn't a priority, I haven't finished and scheduled for later. It is urgent for now ? |
|
@ReidyT No not urgent. Just wanted to know what the status of that was, so I could maybe add this fix there and we would not have to duplicate the code too much. Lets discuss this. |
ReidyT
approved these changes
Jun 10, 2024
Co-authored-by: Thibault Reidy <[email protected]>
spaenleh
force-pushed
the
fix-avatar-upload-size-error
branch
from
7874986 to
aaedbb3
Compare
|
spaenleh
pushed a commit
that referenced
this pull request
Nov 14, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
spaenleh
pushed a commit
that referenced
this pull request
Nov 26, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
spaenleh
pushed a commit
that referenced
this pull request
Jan 23, 2025
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I fix an issue where the user avatar picture was artificially growing in size before being sent to the backend. This resulted in a silent error and failure to update the avatar picture. With this PR I update the code that handles cropping and creating a new image. It uses lossy compression to reduce the file size and ensure we do not hit the limit of 10Mb that we fixed for file uploads.
Maybe this component should be moved to UI alongside a custom hook to compute the image crop. @ReidyT were you working on that recently ?