fix: fix avatar size constant

[mariembencheikh]

fix #246

[spaenleh]

Thank you for the quick fix, it solves the issue.

However I think this only fixes the surface of the problem and the core can still be subject to breakage when changing/refactoring the code. Let me explain:

• There are 3 constants in the app that somehow relate to sizing the big profile picture:
  • AVATAR_SIZE (previously 256, now 200)
  • THUMBNAIL_SETTING_MAX_HEIGHT/WIDTH (200)
  • THUMBNAIL_DIMENSION (200)
• The AvatarUploader component allows to set avatarSize via an optional prop. This component is used only once, and is passed a prop value for avatarSize coming from the AVATAR_SIZE constant, so the THUMBNAIL_DIMENSION is actually never used.
• Different parts of the AvatarUploader UI are sized with different constants, it works if they have the same value, but breaks if one of them is changed.

In the light of these elements can you reconsider the fix and make it less fragile to changes. I think reducing the number or constants that affect the same values should be considered as well as ensuring that the elements that should be the same size depend on the same variable instead of different ones that hold the same value.

Let me know if something is not clear. Also please take this as a nitpicking comment from my side, that tries to improve the current code, instead of duck taping it 😄

[spaenleh]

Nice !

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud