Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: accept query params for validation social links #165

Merged
merged 1 commit into from
Mar 21, 2024
Merged

fix: accept query params for validation social links #165

merged 1 commit into from
Mar 21, 2024

Conversation

LinaYahya
Copy link
Contributor

closes #88

@LinaYahya LinaYahya self-assigned this Mar 19, 2024
@LinaYahya LinaYahya requested a review from spaenleh March 19, 2024 12:23
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

spaenleh
spaenleh approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix. Is it true that this will allow query parameters to be used in the URL, but that they will be scrubbed out when saving (since we only save the social id) ?

@LinaYahya LinaYahya added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit 296e085 Mar 21, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Mar 21, 2024
Merged
@spaenleh spaenleh deleted the 88-fix-twitter-link-queryparams branch March 22, 2024 12:25
spaenleh pushed a commit that referenced this pull request Dec 16, 2024
@renovate
chore(deps): update yarn to v3.6.2 (#165)
4c65d99 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

Assignees

@LinaYahya LinaYahya

Labels
v2.3.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy pasting a profile link from twitter shows up as wrong because it contains a query param
2 participants
@LinaYahya @spaenleh