Skip to content

Commit

Permalink
fix: ci issues (#542)
Browse files Browse the repository at this point in the history
* fix: ci issues

* fix: update lock

* fix: deployment
  • Loading branch information
spaenleh authored Dec 12, 2024
1 parent 712666b commit bc66413
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 88 deletions.
9 changes: 4 additions & 5 deletions .github/workflows/deploy-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,7 @@ jobs:
# Replace input build-folder or version if needed
with:
build-folder: "build"
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID_DEV }}
aws-region: ${{ secrets.AWS_REGION_DEV }}
aws-s3-bucket-name: ${{ secrets.AWS_S3_BUCKET_NAME_GRAASP_ACCOUNT_DEV }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY_DEV }}
cloudfront-distribution-id: ${{ secrets.CLOUDFRONT_DISTRIBUTION_GRAASP_ACCOUNT_DEV }}
role-to-assume: ${{ secrets.AWS_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
aws-s3-bucket-name: ${{ vars.AWS_S3_BUCKET_NAME }}
cloudfront-distribution-id: ${{ vars.AWS_CLOUDFRONT_DISTRIBUTION_ID }}
9 changes: 4 additions & 5 deletions .github/workflows/deploy-prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,7 @@ jobs:
# Replace input build-folder or version if needed
with:
build-folder: "build"
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID_PROD }}
aws-region: ${{ secrets.AWS_REGION_PROD }}
aws-s3-bucket-name: ${{ secrets.AWS_S3_BUCKET_NAME_GRAASP_ACCOUNT }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY_PROD }}
cloudfront-distribution-id: ${{ secrets.CLOUDFRONT_DISTRIBUTION_GRAASP_ACCOUNT }}
role-to-assume: ${{ secrets.AWS_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
aws-s3-bucket-name: ${{ vars.AWS_S3_BUCKET_NAME }}
cloudfront-distribution-id: ${{ vars.AWS_CLOUDFRONT_DISTRIBUTION_ID }}
9 changes: 4 additions & 5 deletions .github/workflows/deploy-stage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,7 @@ jobs:
# Replace input build-folder or version if needed
with:
build-folder: "build"
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID_STAGE }}
aws-region: ${{ secrets.AWS_REGION_STAGE }}
aws-s3-bucket-name: ${{ secrets.AWS_S3_BUCKET_NAME_GRAASP_ACCOUNT_STAGE }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY_STAGE }}
cloudfront-distribution-id: ${{ secrets.CLOUDFRONT_DISTRIBUTION_GRAASP_ACCOUNT_STAGE }}
role-to-assume: ${{ secrets.AWS_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
aws-s3-bucket-name: ${{ vars.AWS_S3_BUCKET_NAME }}
cloudfront-distribution-id: ${{ vars.AWS_CLOUDFRONT_DISTRIBUTION_ID }}
2 changes: 1 addition & 1 deletion cypress.config.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import setupCoverage from '@cypress/code-coverage/task';
import setupCoverage from '@cypress/code-coverage/task.js';
import { defineConfig } from 'cypress';

export default defineConfig({
Expand Down
1 change: 1 addition & 0 deletions eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export default [
{
ignores: [
'node_modules/*',
'storybook-static/*',
'public/*',
'dist/*',
'build',
Expand Down
4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,10 @@
"Basile Spaenlehauer"
],
"engines": {
"node": ">=20"
"node": ">=22"
},
"type": "module",
"dependencies": {
"@5.4.6": "link:@graasp/@5.4.6",
"@emotion/cache": "11.14.0",
"@emotion/react": "11.14.0",
"@emotion/styled": "11.14.0",
Expand Down Expand Up @@ -96,7 +95,6 @@
]
},
"devDependencies": {
"@chromatic-com/storybook": "^3.2.2",
"@commitlint/cli": "19.6.0",
"@commitlint/config-conventional": "19.6.0",
"@cypress/code-coverage": "3.13.9",
Expand Down
69 changes: 0 additions & 69 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit bc66413

Please sign in to comment.