fix: code smell

graasp · Jan 14, 2025 · 5c13d58 · 5c13d58
1 parent 12f59b1
commit 5c13d58
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 317 deletions.
diff --git a/src/modules/account/home/memberAnalytics/MemberActionsChart.tsx b/src/modules/account/home/memberAnalytics/MemberActionsChart.tsx
@@ -31,6 +31,24 @@ import {
 import { MyAnalyticsDateRangeDataContext } from '~analytics/context/MyAnalyticsDateRangeContext';
 import { groupActions } from '~analytics/utils';
 
+function getFreqFromData(actions: [string, Action[]][]) {
+  const { months, days, years } = intervalToDuration({
+    start: new Date(actions[0]?.[0]),
+    end: new Date(actions[1]?.[0]),
+  });
+
+  // get bar interval
+  if (years && years >= 1) {
+    return GroupByInterval.Year;
+  } else if (days === 1) {
+    return GroupByInterval.Day;
+  } else if (months === 1 && !days) {
+    return GroupByInterval.Month;
+  } else {
+    return 'other';
+  }
+}
+
 export function MemberActionsChart({
   actions,
 }: Readonly<{
@@ -56,32 +74,18 @@ export function MemberActionsChart({
     isLargeScreen ? MAX_BARS_LARGE_SCREEN : MAX_BARS_SMALL_SCREEN,
   );
 
-  const actionsEntires = Object.entries(groupedActionsByInterval);
+  const actionsEntries = Object.entries(groupedActionsByInterval);
+  const freq = getFreqFromData(actionsEntries);
 
-  const { months, days, years } = intervalToDuration({
-    start: new Date(actionsEntires[0]?.[0]),
-    end: new Date(actionsEntires[1]?.[0]),
-  });
-
-  // get bar interval
-  const freq =
-    years && years >= 1
-      ? GroupByInterval.Year
-      : days === 1
-        ? GroupByInterval.Day
-        : months === 1 && !days
-          ? GroupByInterval.Month
-          : 'other';
-
-  const noOfActionTypesOverInterval = actionsEntires.map(
+  const noOfActionTypesOverInterval = actionsEntries.map(
     ([dateString, localActions], index) => {
       const actionsOverIntervalTypeCounts = countBy(localActions, 'type');
 
       // getting chart x-axis title for specified interval
       let title = '';
       const date = new Date(dateString);
       const nextDate = new Date(
-        actionsEntires[index + 1]?.[0] || dateRange.endDate,
+        actionsEntries[index + 1]?.[0] || dateRange.endDate,
       );
 
       switch (freq) {

diff --git a/src/modules/analytics/mockServer/database.ts b/src/modules/analytics/mockServer/database.ts
diff --git a/src/modules/analytics/mockServer/mockServer.ts b/src/modules/analytics/mockServer/mockServer.ts
diff --git a/src/modules/landing/Platforms/PlatformCube.tsx b/src/modules/landing/Platforms/PlatformCube.tsx
@@ -20,7 +20,7 @@ import {
 
 import { PlatformColorSurface } from './PlatformColorSurface';
 
-function Row({ children }: { children: ReactNode }) {
+function Row({ children }: Readonly<{ children: ReactNode }>) {
   return (
     <Stack direction={{ xs: 'column', sm: 'row' }} gap="2px">
       {children}