fix: code smells (#497)

* fix: code smells * fix: revert change to use isValid from react-hook-form
graasp · Nov 28, 2024 · 2408533 · 2408533
1 parent c623f4b
commit 2408533
Show file tree

Hide file tree

Showing 26 changed files with 123 additions and 433 deletions.
diff --git a/src/components/layout/BorderedSection.tsx b/src/components/layout/BorderedSection.tsx
@@ -15,7 +15,7 @@ export function BorderedSection({
   title,
   topActions,
   children,
-}: BorderedSectionProps): JSX.Element {
+}: Readonly<BorderedSectionProps>): JSX.Element {
   return (
     <RoundedStack id={id}>
       <Stack direction="row" justifyContent="space-between">

diff --git a/src/components/layout/CenteredContainer.tsx b/src/components/layout/CenteredContainer.tsx
@@ -4,24 +4,25 @@ import { Container, Stack } from '@mui/material';
 
 import { DEFAULT_BACKGROUND_COLOR } from '@graasp/ui';
 
-const CenteredContainer = ({
+export function CenteredContainer({
   children,
-}: {
+}: Readonly<{
   children: ReactNode;
-}): JSX.Element => (
-  <Stack height="100vh" bgcolor={DEFAULT_BACKGROUND_COLOR}>
-    <Container sx={{ my: 5, height: '100%' }}>
-      <Stack
-        height="100%"
-        direction="column"
-        alignItems="center"
-        justifyContent="center"
-        flexGrow={1}
-        gap={2}
-      >
-        {children}
-      </Stack>
-    </Container>
-  </Stack>
-);
-export default CenteredContainer;
+}>): JSX.Element {
+  return (
+    <Stack height="100vh" bgcolor={DEFAULT_BACKGROUND_COLOR}>
+      <Container sx={{ my: 5, height: '100%' }}>
+        <Stack
+          height="100%"
+          direction="column"
+          alignItems="center"
+          justifyContent="center"
+          flexGrow={1}
+          gap={2}
+        >
+          {children}
+        </Stack>
+      </Container>
+    </Stack>
+  );
+}
diff --git a/src/config/selectors.ts b/src/config/selectors.ts
@@ -132,7 +132,6 @@ export const USER_SWITCH_ID = 'userSwitch';
 export const SUCCESS_CONTENT_ID = 'successContent';
 export const BACK_BUTTON_ID = 'backButtonId';
 export const RESEND_EMAIL_BUTTON_ID = 'resendEmailButton';
-export const buildMemberMenuItemId = (id: string) => `memberMenuItemId-${id}`;
 export const PASSWORD_SUCCESS_ALERT = 'passwordSuccessAlert';
 
 export const PLATFORM_ADVERTISEMENT_CONTAINER_ID =

diff --git a/src/modules/auth/components/requestPasswordReset/ResetPassword.tsx b/src/modules/auth/components/requestPasswordReset/ResetPassword.tsx
diff --git a/src/modules/player/Chatbox.tsx b/src/modules/player/Chatbox.tsx
@@ -17,7 +17,7 @@ const {
 type Props = {
   item: DiscriminatedItem;
 };
-// todo: add chatbox in the project
+
 const Chatbox = ({ item }: Props): JSX.Element => {
   const { data: messages, isLoading: isChatLoading } = useItemChat(item.id);
   const { data: itemPermissions, isLoading: isLoadingItemPermissions } =

diff --git a/src/modules/player/ItemNavigation.tsx b/src/modules/player/ItemNavigation.tsx
@@ -12,7 +12,7 @@ import { NS } from '@/config/constants.ts';
 import { axios, hooks } from '@/config/queryClient';
 import { MAIN_MENU_ID, TREE_VIEW_ID } from '@/config/selectors';
 
-import LoadingTree from './tree/LoadingTree.tsx';
+import { LoadingTree } from './tree/LoadingTree.tsx';
 import { TreeView } from './tree/TreeView.tsx';
 import { combineUuids, shuffleAllButLastItemInArray } from './utils/shuffle.ts';
 

diff --git a/src/modules/player/config/selectors.ts b/src/modules/player/config/selectors.ts
diff --git a/src/modules/player/errors/FallbackComponent.tsx b/src/modules/player/errors/FallbackComponent.tsx
@@ -6,7 +6,7 @@ import { Box, Stack, Typography } from '@mui/material';
 import { ButtonLink } from '@/components/ui/ButtonLink';
 import { NS } from '@/config/constants';
 
-const FallbackComponent = (): JSX.Element => {
+export function FallbackComponent(): JSX.Element {
   const { t: translateBuilder } = useTranslation(NS.Player);
 
   return (
@@ -41,6 +41,4 @@ const FallbackComponent = (): JSX.Element => {
       />
     </Stack>
   );
-};
-
-export default FallbackComponent;
+}
diff --git a/src/modules/player/errors/NetworkErrorAlert.tsx b/src/modules/player/errors/NetworkErrorAlert.tsx
@@ -1,6 +1,5 @@
 import { useTranslation } from 'react-i18next';
 
-import Refresh from '@mui/icons-material/Refresh';
 import {
   Alert,
   AlertTitle,
@@ -10,6 +9,8 @@ import {
   Typography,
 } from '@mui/material';
 
+import { RefreshCwIcon } from 'lucide-react';
+
 import { NS } from '@/config/constants';
 
 export function NetworkErrorAlert(): JSX.Element {
@@ -29,7 +30,7 @@ export function NetworkErrorAlert(): JSX.Element {
           <Tooltip title="Reload">
             <span>
               <IconButton onClick={() => window.location.reload()}>
-                <Refresh />
+                <RefreshCwIcon />
               </IconButton>
             </span>
           </Tooltip>