Add example for embedding simple python scripts and debugging them using VSCode #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
timfel
force-pushed
the
tim/graalpy-vscode
branch
2 times, most recently
from
e3c3cbc to
9b75d60
Compare
steve-s
reviewed
Nov 28, 2024
steve-s
reviewed
Nov 28, 2024
|
|
||
| ```shell | ||
| ./mvnw compile | ||
| ./mvnw javafx:run |
There was a problem hiding this comment.
When I followed the JavaFX quickstart from https://openjfx.io/openjfx-docs/#maven it did not generate the wrapper. Maybe this should be mvn compiler etc. or mention something like "if you don't use Maven wrapper, the commands would be ...".
There was a problem hiding this comment.
Ouch, the project generated by javafx-archetype-simple seem to be broken on many fronts...
- it sets
maven-compiler-pluginto version3.8.0, but that seems to be broken so one must manually update to at least3.8.1 - it generates
module-info.java, so javac does module stuff and since polyglot is a proper module, one has to addrequires org.graalvm.polyglot;to the generatedmodule-info.java. - after fixing all that it fails in runtime on some Java module permission issue
All in all, maybe it's easier to not even mention this Java FX quickstart guide..?
There was a problem hiding this comment.
I just ran through the thing again, just copied the quickstart from JavaFX and used local maven to go through the readme and i got a working project 🤔
steve-s
reviewed
Nov 28, 2024
timfel
force-pushed
the
tim/graalpy-vscode
branch
from
9b75d60 to
6fc8e96
Compare
timfel
force-pushed
the
tim/graalpy-vscode
branch
from
6fc8e96 to
43f5daa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.