Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add organizations and contact points per country to statistics table #489

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ainali
Copy link
Member

@Ainali Ainali commented Jan 10, 2025

Description

Adding count per country to the table.

Issue Reference

Fixes #254

Checklist

Please ensure the following before submitting the PR:

  • I have tested the changes locally, and they work as expected.
  • The code follows the project's coding standards and conventions.
  • I have updated relevant documentation (if needed).
  • I have added unit tests or performed manual testing where necessary.

Screenshots (applicable to user interface changes)

image

@Ainali Ainali requested a review from Abbe98 January 10, 2025 17:15
Copy link
Member

@Abbe98 Abbe98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Only some minor comments from me.

templates/statistics.html Show resolved Hide resolved
{{- $other_cp = add1 $other_cp -}}
{{- end -}}
{{- end -}}
<td lang="{{ .description.Lang }}"><a href="../{{ .safeName }}/">{{ .name }}</a></td>
<td lang="{{ .description.Lang }}">{{ .description }}</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice with a max-width of ~500px to ensure that the contact points title doesn't break on large screens.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I liked that it broke on my screen to make the column narrower.

@Ainali Ainali force-pushed the per-country-stats branch from ca96c0e to 001a545 Compare January 10, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The statistics view should display contact points per country
2 participants