Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOVCMSD8-362] Add findutils to govcms8lagoon cli and test images #45

Merged
merged 2 commits into from
May 14, 2019

Conversation

tobybellwood
Copy link

@tobybellwood tobybellwood commented May 12, 2019

in govCMS/audit-site#34 some tests were identified as relying on find options not supported in the OOTB version of find.

This PR adds the full GNU findutils package to restore this functionality - it also modifies the apk command to not leave a cache in the end product image

APK adds can be removed if/when uselagoon/lagoon#1077 lands.

@tobybellwood tobybellwood changed the title Add findutils to cli and test images Add findutils to govcms8lagoon cli and test images May 12, 2019
Copy link
Contributor

@fubarhouse fubarhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobybellwood tobybellwood changed the title Add findutils to govcms8lagoon cli and test images [GOVCMSD8-362] Add findutils to govcms8lagoon cli and test images May 13, 2019
@tobybellwood tobybellwood merged commit 292deb2 into govCMS:master May 14, 2019
@tobybellwood tobybellwood deleted the feature/findutils branch May 14, 2019 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants