Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap prebuild setupdesign library with the OSS version. #206

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Swap prebuild setupdesign library with the OSS version. #206

merged 1 commit into from
Mar 26, 2024

Conversation

pfmaggi
Copy link
Collaborator

@pfmaggi pfmaggi commented Mar 26, 2024 •
edited
Loading

Based on top of @ahumesky's PR this fixes #191:

  • Remove prebuild setupdesign and setupcompat libraries
  • Add Bazel's build for setupdesign and setupcompat
  • Update WORKSPACE to patch setupdesign library to support Java 8
  • Remove appComponentFactory in AndroidManifest.xml
  • Fix in SUW layouts (sucUsePartnerResource)

@pfmaggi pfmaggi requested a review from jscott1989 March 26, 2024 18:09
@pfmaggi pfmaggi added the bazel Issues related to the Bazel build system. label Mar 26, 2024
@pfmaggi pfmaggi merged commit 6d9ecd8 into googlesamples:master Mar 26, 2024
1 check passed
@SM2A
Copy link
Contributor

SM2A commented Mar 28, 2024

Hi
What was wrong with android_local_test?
Why while android_local_test are commented robolectric library is still there?
@pfmaggi @jscott1989

@pfmaggi
Copy link
Collaborator Author

pfmaggi commented Mar 28, 2024

I had some issues with the android_local_test rules and I disabled it for the moment.

The plan is to enable them again once they are fixed.

@SM2A
Copy link
Contributor

SM2A commented Mar 28, 2024

Is there anything I can help with?

@pfmaggi
Copy link
Collaborator Author

pfmaggi commented Apr 5, 2024

I filed #207 to track this. It would be nice to have a working testing setup with Bazel but I don't have time to work on this at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jscott1989 jscott1989 jscott1989 approved these changes

Assignees
No one assigned
Labels
bazel Issues related to the Bazel build system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Couldn't launch 'test dpc' app built myself
3 participants
@pfmaggi @SM2A @jscott1989