Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GMSMapView SwiftUI Implementation #225

Merged
merged 19 commits into from
Dec 18, 2024
Merged

Conversation

waynewbishop
Copy link
Collaborator

@waynewbishop waynewbishop commented Dec 2, 2024

GMSMapView SwiftUI Implementation

This PR introduces a modern SwiftUI wrapper around GMSMapView that simplifies integration of Google Maps into SwiftUI applications. The implementation provides a declarative API through custom view modifiers for common map configurations like adding markers and handling user interactions.

The GoogleMapViewDelegate has been designed to use closure-based callbacks, making it easier to handle map events in a SwiftUI-friendly way. The overall architecture emphasizes type safety and follows SwiftUI best practices for state management and view updates.

@waynewbishop waynewbishop requested a review from wangela December 2, 2024 03:52
@waynewbishop waynewbishop self-assigned this Dec 2, 2024
Copy link
Contributor

@wangela wangela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are the demo names and descriptions (e.g. where are they defined to be visible when running the demo app)? I'm trying to figure out how you differentiate between "MapWithMarker" and "MapWithMarkers"

Copy link
Contributor

@wangela wangela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add:

  • BasicMapWithMapID
  • Add mention of this folder to README

@waynewbishop
Copy link
Collaborator Author

To add:

  • BasicMapWithMapID
  • Add mention of this folder to README

Changes complete. These include:

  • A new BasicMapWithMapID sample
  • New updates to Readme.md supporting the addition of the new GoogleMaps-SwiftUI sub-directory.

@wangela wangela merged commit aef8f9a into googlemaps-samples:main Dec 18, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants