-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GMSMapView SwiftUI Implementation #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are the demo names and descriptions (e.g. where are they defined to be visible when running the demo app)? I'm trying to figure out how you differentiate between "MapWithMarker" and "MapWithMarkers"
GoogleMaps-SwiftUI/GoogleMaps-SwiftUI/GoogleMaps_SwiftUIApp.swift
Outdated
Show resolved
Hide resolved
GoogleMaps-SwiftUI/GoogleMaps-SwiftUI/GoogleMaps_SwiftUIApp.swift
Outdated
Show resolved
Hide resolved
GoogleMaps-SwiftUI/GoogleMaps-SwiftUI/GoogleMapView/GoogleMapView.swift
Outdated
Show resolved
Hide resolved
GoogleMaps-SwiftUI/GoogleMaps-SwiftUI/Samples/MapWithStreetLevel.swift
Outdated
Show resolved
Hide resolved
GoogleMaps-SwiftUI/GoogleMaps-SwiftUI/Samples/MapWithTypes.swift
Outdated
Show resolved
Hide resolved
GoogleMaps-SwiftUI/GoogleMaps-SwiftUI/Samples/MapWithDelegate.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To add:
- BasicMapWithMapID
- Add mention of this folder to README
Changes complete. These include:
|
GMSMapView SwiftUI Implementation
This PR introduces a modern SwiftUI wrapper around
GMSMapView
that simplifies integration of Google Maps into SwiftUI applications. The implementation provides a declarative API through custom view modifiers for common map configurations like adding markers and handling user interactions.The
GoogleMapViewDelegate
has been designed to use closure-based callbacks, making it easier to handle map events in a SwiftUI-friendly way. The overall architecture emphasizes type safety and follows SwiftUI best practices for state management and view updates.