Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

Fix error when parent is null in core-overlay #67

Closed
wants to merge 1 commit into from
Closed

Fix error when parent is null in core-overlay #67

wants to merge 1 commit into from

Conversation

jjaeggli
Copy link

When unit testing a component using paper-action-dialog, the test fails when opened is toggled on the element with the following errors:

core-overlay.html:458: Uncaught TypeError: Cannot read property 'removeChild' of null

and subsequently when the above error was addressed:

core-overlay-layer.html:92: Uncaught TypeError: Cannot read property 'removeChild' of null

these errors seem to correspond to the issue reported here:
dart-archive/paper-elements#83

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@jjaeggli
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@jjaeggli jjaeggli closed this by deleting the head repository Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants