-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for restore token #2548
Conversation
Merge branch 'googleapis:main' into support-for-restore-token
@@ -547,6 +551,7 @@ class File extends ServiceObject<File, FileMetadata> { | |||
name: string; | |||
|
|||
generation?: number; | |||
restoreToken?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to have this field as both a class level and metadata level field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed that in some scenarios, a refresh token is associated with a specific generation ID. To ensure consistent behavior and avoid potential issues, I've implemented the refresh token handling in a way that aligns with the generation ID concept. This approach will help maintain data integrity and security.
My understanding is that the restore token would be returned on a call to delete. Is that going to be a separate PR or should it be included here? |
I'm currently focused on implementing support for restore tokens in the get, list, and restore operations. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #restoreToken