Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: various sample and doc improvements we had queued up #1987

Merged
merged 6 commits into from
Oct 18, 2024
Merged

samples: various sample and doc improvements we had queued up #1987

merged 6 commits into from
Oct 18, 2024

Conversation

feywind
Copy link
Collaborator

@feywind feywind commented Oct 17, 2024 

samples: update EOD sample with endpoint
docs: clarify what subscriber batching means
samples: update publishWithRetrySettings with new defaults; add comment about including all items
samples: convert publishWithRetrySettings to use veneer
samples: update publishing samples to clarify that topic objects should be cached; also fix a usage of publish()

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the googleapis/nodejs-pubsub API. samples Issues that are directly related to samples. labels Oct 17, 2024
@feywind feywind marked this pull request as ready for review October 18, 2024 17:17
@feywind feywind requested review from a team as code owners October 18, 2024 17:17
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 18, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 18, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Oct 18, 2024
@feywind feywind added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 18, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 18, 2024
@feywind feywind merged commit 858b565 into googleapis:main Oct 18, 2024
15 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 18, 2024
@feywind feywind deleted the improve-samples branch October 18, 2024 19:07
@feywind feywind mentioned this pull request Oct 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpri10 michaelpri10 michaelpri10 approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feywind @michaelpri10