-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: add samples for cloud storage buckets #1931
Conversation
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
It's only one sample for now, this is good to go again. |
Warning: This pull request is touching the following templated files:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall!
// Creates a client; cache this for further use | ||
const pubSubClient = new PubSub(); | ||
|
||
async function createSubscriptionWithCloudStorage( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe name this createCloudStorageSubscription instead of createSubscriptionWithCloudStorage? Same suggestion applies to the typescript sample.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I picked createSubscriptionWithCloudStorage because the library has five others with that naming scheme from earlier. Unless there's a strong objection, I think I'd probably keep the current name for that reason. Actually, the sample tags are all over the place already, so I don't think I'd want to try to fix it in this PR.
- pubsub_create_cloud_storage_subscription (this one)
- pubsub_dead_letter_create_subscription (createSubscriptionWithDeadLetterPolicy)
- pubsub_create_subscription_with_exactly_once_delivery (createSubscriptionWithExactlyOnceDelivery)
- pubsub_create_subscription_with_filter (createSubscriptionWithFiltering)
- pubsub_enable_subscription_ordering (createSubscriptionWithOrdering)
- createSubscriptionWithRetryPolicy - doesn't seem to have sample tags at all (??)
Maybe for the purposes of this PR, I'll just update the function name to match the tag and leave the filename as-is.
…-cloud-storage-subs
Fixes: #1742