Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: correct max messages #1874

Merged
merged 4 commits into from
Jan 31, 2024
Merged

docs: correct max messages #1874

merged 4 commits into from
Jan 31, 2024

Conversation

richardnias
Copy link
Contributor

@richardnias richardnias commented Jan 26, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1744 🦕

Note: If you are opening a pull request against a legacy branch, PLEASE BE AWARE that we generally won't accept these except for things like important security fixes, and only for a limited time.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Jan 26, 2024
@richardnias richardnias changed the title Docs correct max messages docs: correct max messages Jan 26, 2024
@richardnias richardnias marked this pull request as ready for review January 26, 2024 10:00
@richardnias richardnias requested review from a team as code owners January 26, 2024 10:00
feywind
feywind previously approved these changes Jan 31, 2024
View reviewed changes
@feywind
Copy link
Collaborator

feywind commented Jan 31, 2024

Thank you for the PR, I'll queue this up behind a few others I've got building.

@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 31, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 31, 2024
@feywind feywind added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit labels Jan 31, 2024
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: xs Pull request size is extra small. labels Jan 31, 2024
@gcf-merge-on-green gcf-merge-on-green bot dismissed feywind’s stale review January 31, 2024 19:06

This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 31, 2024
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: xl Pull request size is extra large. labels Jan 31, 2024
@feywind feywind added automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit and removed automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit labels Jan 31, 2024
feywind
feywind approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@feywind feywind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving for automerge.

@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 31, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 31, 2024
@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 31, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 31, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 6bfde07 into googleapis:main Jan 31, 2024
15 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feywind feywind feywind approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subscription maxMessages documented incorrectly
3 participants
@richardnias @feywind @yoshi-kokoro