Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the MetricsTracerFactory for client side metrics #1566

Draft
wants to merge 83 commits into
base: main
Choose a base branch
from

Conversation

danieljbruce
Copy link
Contributor

Summary:

This PR adds the MetricsTracerFactory which the rest of the client library will use to collect client side metrics to send to GCP backend for analysis. None of the methods will use MetricsTracerFactory yet so this PR doesn't change client library behaviour in any way. It is just in the stage of building infrastructure to support client side metrics.

Changes:

TODO

Next Steps:

  1. Write some system tests using this new test infrastructure that logs metrics collected and ensure the metrics collected are what we would expect.
  2. Add client side metrics to readRows calls
  3. Add client side metrics to other calls

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigtable Issues related to the googleapis/nodejs-bigtable API. labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant