feat: Adding gfe_latencies metric to built-in metrics #3490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
surbhigarg92
force-pushed
the
gfe_latency
branch
2 times, most recently
from
085d5b8 to
7383362
Compare
HailongWen
reviewed
Dec 11, 2024
| TagContext tagContext, | ||
| Attributes attributes, | ||
| Span span, | ||
| Map<String, String> builtInMetricsAttributes) { | ||
| MeasureMap measureMap = STATS_RECORDER.newMeasureMap(); | ||
| String serverTiming = metadata.get(SERVER_TIMING_HEADER_KEY); | ||
| if (serverTiming != null && serverTiming.startsWith(SERVER_TIMING_HEADER_PREFIX)) { |
There was a problem hiding this comment.
Can we make this compatible with other server timing headers?
There was a problem hiding this comment.
More specifically, a server timing header is in the format of [component]; dur=[latency], as stated in the w3c standard. gfet4t7 is just one of the possible component and it is not guaranteed to be the first one, so startsWith shall be changed to something like contains.
surbhigarg92
force-pushed
the
gfe_latency
branch
from
b6bd6f2 to
3b03055
Compare
product-auto-label
bot
added
size: l
surbhigarg92
force-pushed
the
gfe_latency
branch
from
105edeb to
59459ae
Compare
surbhigarg92
force-pushed
the
gfe_latency
branch
from
6e6e94b to
6fbf28c
Compare
surbhigarg92
changed the title
surbhigarg92
added
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.