Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Many APIs] paging changes for bigquery #5994

Closed
wants to merge 4 commits into from
Closed

feat: [Many APIs] paging changes for bigquery #5994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
54134df
feat: paging changes for bigquery
gcf-owl-bot[bot] Jan 29, 2025
2dfeecf
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 29, 2025
2f15102
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 29, 2025
0a2095a
Merge branch 'owl-bot-copy-8eaabf0b71b2a8204e74' of https://github.co…
gcf-owl-bot[bot] Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/google-cloud-binaryauthorization/src/v1/binauthz_management_service_v1_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1107,7 +1107,7 @@ export class BinauthzManagementServiceV1Client {
}

/**
* Equivalent to `method.name.toCamelCase()`, but returns a NodeJS Stream object.
* Equivalent to `listAttestors`, but returns a NodeJS Stream object.
* @param {Object} request
* The request object that will be sent.
* @param {string} request.parent
Expand Down
2 changes: 1 addition & 1 deletion ...ogle-cloud-binaryauthorization/src/v1beta1/binauthz_management_service_v1_beta1_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1113,7 +1113,7 @@ export class BinauthzManagementServiceV1Beta1Client {
}

/**
* Equivalent to `method.name.toCamelCase()`, but returns a NodeJS Stream object.
* Equivalent to `listAttestors`, but returns a NodeJS Stream object.
* @param {Object} request
* The request object that will be sent.
* @param {string} request.parent
Expand Down
50 changes: 25 additions & 25 deletions ...ogle-cloud-binaryauthorization/test/gapic_binauthz_management_service_v1_beta1_v1beta1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ describe('v1beta1.BinauthzManagementServiceV1Beta1Client', () => {
['name']
);
request.name = defaultValue1;
const expectedHeaderRequestParams = `name=${defaultValue1}`;
const expectedHeaderRequestParams = `name=${defaultValue1 ?? ''}`;
const expectedResponse = generateSampleMessage(
new protos.google.cloud.binaryauthorization.v1beta1.Policy()
);
Expand Down Expand Up @@ -394,7 +394,7 @@ describe('v1beta1.BinauthzManagementServiceV1Beta1Client', () => {
['name']
);
request.name = defaultValue1;
const expectedHeaderRequestParams = `name=${defaultValue1}`;
const expectedHeaderRequestParams = `name=${defaultValue1 ?? ''}`;
const expectedResponse = generateSampleMessage(
new protos.google.cloud.binaryauthorization.v1beta1.Policy()
);
Expand Down Expand Up @@ -444,7 +444,7 @@ describe('v1beta1.BinauthzManagementServiceV1Beta1Client', () => {
['name']
);
request.name = defaultValue1;
const expectedHeaderRequestParams = `name=${defaultValue1}`;
const expectedHeaderRequestParams = `name=${defaultValue1 ?? ''}`;
const expectedError = new Error('expected');
client.innerApiCalls.getPolicy = stubSimpleCall(undefined, expectedError);
await assert.rejects(client.getPolicy(request), expectedError);
Expand Down Expand Up @@ -500,7 +500,7 @@ describe('v1beta1.BinauthzManagementServiceV1Beta1Client', () => {
['policy', 'name']
);
request.policy.name = defaultValue1;
const expectedHeaderRequestParams = `policy.name=${defaultValue1}`;
const expectedHeaderRequestParams = `policy.name=${defaultValue1 ?? ''}`;
const expectedResponse = generateSampleMessage(
new protos.google.cloud.binaryauthorization.v1beta1.Policy()
);
Expand Down Expand Up @@ -535,7 +535,7 @@ describe('v1beta1.BinauthzManagementServiceV1Beta1Client', () => {
['policy', 'name']
);
request.policy.name = defaultValue1;
const expectedHeaderRequestParams = `policy.name=${defaultValue1}`;
const expectedHeaderRequestParams = `policy.name=${defaultValue1 ?? ''}`;
const expectedResponse = generateSampleMessage(
new protos.google.cloud.binaryauthorization.v1beta1.Policy()
);
Expand Down Expand Up @@ -586,7 +586,7 @@ describe('v1beta1.BinauthzManagementServiceV1Beta1Client', () => {
['policy', 'name']
);
request.policy.name = defaultValue1;
const expectedHeaderRequestParams = `policy.name=${defaultValue1}`;
const expectedHeaderRequestParams = `policy.name=${defaultValue1 ?? ''}`;
const expectedError = new Error('expected');
client.innerApiCalls.updatePolicy = stubSimpleCall(
undefined,
Expand Down Expand Up @@ -645,7 +645,7 @@ describe('v1beta1.BinauthzManagementServiceV1Beta1Client', () => {
['parent']
);
request.parent = defaultValue1;
const expectedHeaderRequestParams = `parent=${defaultValue1}`;
const expectedHeaderRequestParams = `parent=${defaultValue1 ?? ''}`;
const expectedResponse = generateSampleMessage(
new protos.google.cloud.binaryauthorization.v1beta1.Attestor()
);
Expand Down Expand Up @@ -679,7 +679,7 @@ describe('v1beta1.BinauthzManagementServiceV1Beta1Client', () => {
['parent']
);
request.parent = defaultValue1;
const expectedHeaderRequestParams = `parent=${defaultValue1}`;
const expectedHeaderRequestParams = `parent=${defaultValue1 ?? ''}`;
const expectedResponse = generateSampleMessage(
new protos.google.cloud.binaryauthorization.v1beta1.Attestor()
);
Expand Down Expand Up @@ -729,7 +729,7 @@ describe('v1beta1.BinauthzManagementServiceV1Beta1Client', () => {
['parent']
);
request.parent = defaultValue1;
const expectedHeaderRequestParams = `parent=${defaultValue1}`;
const expectedHeaderRequestParams = `parent=${defaultValue1 ?? ''}`;
const expectedError = new Error('expected');
client.innerApiCalls.createAttestor = stubSimpleCall(
undefined,
Expand Down Expand Up @@ -787,7 +787,7 @@ describe('v1beta1.BinauthzManagementServiceV1Beta1Client', () => {
['name']
);
request.name = defaultValue1;
const expectedHeaderRequestParams = `name=${defaultValue1}`;
const expectedHeaderRequestParams = `name=${defaultValue1 ?? ''}`;
const expectedResponse = generateSampleMessage(
new protos.google.cloud.binaryauthorization.v1beta1.Attestor()
);
Expand Down Expand Up @@ -821,7 +821,7 @@ describe('v1beta1.BinauthzManagementServiceV1Beta1Client', () => {
['name']
);
request.name = defaultValue1;
const expectedHeaderRequestParams = `name=${defaultValue1}`;
const expectedHeaderRequestParams = `name=${defaultValue1 ?? ''}`;
const expectedResponse = generateSampleMessage(
new protos.google.cloud.binaryauthorization.v1beta1.Attestor()
);
Expand Down Expand Up @@ -871,7 +871,7 @@ describe('v1beta1.BinauthzManagementServiceV1Beta1Client', () => {
['name']
);
request.name = defaultValue1;
const expectedHeaderRequestParams = `name=${defaultValue1}`;
const expectedHeaderRequestParams = `name=${defaultValue1 ?? ''}`;
const expectedError = new Error('expected');
client.innerApiCalls.getAttestor = stubSimpleCall(
undefined,
Expand Down Expand Up @@ -930,7 +930,7 @@ describe('v1beta1.BinauthzManagementServiceV1Beta1Client', () => {
['attestor', 'name']
);
request.attestor.name = defaultValue1;
const expectedHeaderRequestParams = `attestor.name=${defaultValue1}`;
const expectedHeaderRequestParams = `attestor.name=${defaultValue1 ?? ''}`;
const expectedResponse = generateSampleMessage(
new protos.google.cloud.binaryauthorization.v1beta1.Attestor()
);
Expand Down Expand Up @@ -965,7 +965,7 @@ describe('v1beta1.BinauthzManagementServiceV1Beta1Client', () => {
['attestor', 'name']
);
request.attestor.name = defaultValue1;
const expectedHeaderRequestParams = `attestor.name=${defaultValue1}`;
const expectedHeaderRequestParams = `attestor.name=${defaultValue1 ?? ''}`;
const expectedResponse = generateSampleMessage(
new protos.google.cloud.binaryauthorization.v1beta1.Attestor()
);
Expand Down Expand Up @@ -1016,7 +1016,7 @@ describe('v1beta1.BinauthzManagementServiceV1Beta1Client', () => {
['attestor', 'name']
);
request.attestor.name = defaultValue1;
const expectedHeaderRequestParams = `attestor.name=${defaultValue1}`;
const expectedHeaderRequestParams = `attestor.name=${defaultValue1 ?? ''}`;
const expectedError = new Error('expected');
client.innerApiCalls.updateAttestor = stubSimpleCall(
undefined,
Expand Down Expand Up @@ -1075,7 +1075,7 @@ describe('v1beta1.BinauthzManagementServiceV1Beta1Client', () => {
['name']
);
request.name = defaultValue1;
const expectedHeaderRequestParams = `name=${defaultValue1}`;
const expectedHeaderRequestParams = `name=${defaultValue1 ?? ''}`;
const expectedResponse = generateSampleMessage(
new protos.google.protobuf.Empty()
);
Expand Down Expand Up @@ -1109,7 +1109,7 @@ describe('v1beta1.BinauthzManagementServiceV1Beta1Client', () => {
['name']
);
request.name = defaultValue1;
const expectedHeaderRequestParams = `name=${defaultValue1}`;
const expectedHeaderRequestParams = `name=${defaultValue1 ?? ''}`;
const expectedResponse = generateSampleMessage(
new protos.google.protobuf.Empty()
);
Expand Down Expand Up @@ -1159,7 +1159,7 @@ describe('v1beta1.BinauthzManagementServiceV1Beta1Client', () => {
['name']
);
request.name = defaultValue1;
const expectedHeaderRequestParams = `name=${defaultValue1}`;
const expectedHeaderRequestParams = `name=${defaultValue1 ?? ''}`;
const expectedError = new Error('expected');
client.innerApiCalls.deleteAttestor = stubSimpleCall(
undefined,
Expand Down Expand Up @@ -1217,7 +1217,7 @@ describe('v1beta1.BinauthzManagementServiceV1Beta1Client', () => {
['parent']
);
request.parent = defaultValue1;
const expectedHeaderRequestParams = `parent=${defaultValue1}`;
const expectedHeaderRequestParams = `parent=${defaultValue1 ?? ''}`;
const expectedResponse = [
generateSampleMessage(
new protos.google.cloud.binaryauthorization.v1beta1.Attestor()
Expand Down Expand Up @@ -1259,7 +1259,7 @@ describe('v1beta1.BinauthzManagementServiceV1Beta1Client', () => {
['parent']
);
request.parent = defaultValue1;
const expectedHeaderRequestParams = `parent=${defaultValue1}`;
const expectedHeaderRequestParams = `parent=${defaultValue1 ?? ''}`;
const expectedResponse = [
generateSampleMessage(
new protos.google.cloud.binaryauthorization.v1beta1.Attestor()
Expand Down Expand Up @@ -1319,7 +1319,7 @@ describe('v1beta1.BinauthzManagementServiceV1Beta1Client', () => {
['parent']
);
request.parent = defaultValue1;
const expectedHeaderRequestParams = `parent=${defaultValue1}`;
const expectedHeaderRequestParams = `parent=${defaultValue1 ?? ''}`;
const expectedError = new Error('expected');
client.innerApiCalls.listAttestors = stubSimpleCall(
undefined,
Expand Down Expand Up @@ -1353,7 +1353,7 @@ describe('v1beta1.BinauthzManagementServiceV1Beta1Client', () => {
['parent']
);
request.parent = defaultValue1;
const expectedHeaderRequestParams = `parent=${defaultValue1}`;
const expectedHeaderRequestParams = `parent=${defaultValue1 ?? ''}`;
const expectedResponse = [
generateSampleMessage(
new protos.google.cloud.binaryauthorization.v1beta1.Attestor()
Expand Down Expand Up @@ -1419,7 +1419,7 @@ describe('v1beta1.BinauthzManagementServiceV1Beta1Client', () => {
['parent']
);
request.parent = defaultValue1;
const expectedHeaderRequestParams = `parent=${defaultValue1}`;
const expectedHeaderRequestParams = `parent=${defaultValue1 ?? ''}`;
const expectedError = new Error('expected');
client.descriptors.page.listAttestors.createStream =
stubPageStreamingCall(undefined, expectedError);
Expand Down Expand Up @@ -1474,7 +1474,7 @@ describe('v1beta1.BinauthzManagementServiceV1Beta1Client', () => {
['parent']
);
request.parent = defaultValue1;
const expectedHeaderRequestParams = `parent=${defaultValue1}`;
const expectedHeaderRequestParams = `parent=${defaultValue1 ?? ''}`;
const expectedResponse = [
generateSampleMessage(
new protos.google.cloud.binaryauthorization.v1beta1.Attestor()
Expand Down Expand Up @@ -1527,7 +1527,7 @@ describe('v1beta1.BinauthzManagementServiceV1Beta1Client', () => {
['parent']
);
request.parent = defaultValue1;
const expectedHeaderRequestParams = `parent=${defaultValue1}`;
const expectedHeaderRequestParams = `parent=${defaultValue1 ?? ''}`;
const expectedError = new Error('expected');
client.descriptors.page.listAttestors.asyncIterate =
stubAsyncIterationCall(undefined, expectedError);
Expand Down
Loading
Loading