Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layer): ensure layer references are unset when the associated layer is deleted #669

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix(layer): ensure layer references are unset when the associated layer is deleted #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/layer/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,6 +955,7 @@ export class LayerManager extends RefCounted {
// Also notify the root LayerManager, to ensures the layer is removed if this is the last direct
// reference.
managedLayer.manager.rootLayers.layersChanged.dispatch();
managedLayer.manager.rootLayers.specificationChanged.dispatch();
managedLayer.dispose();
}

Expand Down
6 changes: 0 additions & 6 deletions src/shared_disjoint_sets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,6 @@ export class SharedDisjointUint64Sets
return obj;
}

disposed() {
this.disjointSets = <any>undefined;
this.changed = <any>undefined;
super.disposed();
}

link(a: Uint64, b: Uint64) {
if (this.disjointSets.link(a, b)) {
const { rpc } = this;
Expand Down
Loading