Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added constant pi and several math functions #1187

Merged
merged 5 commits into from
Jan 18, 2025

Conversation

rben01
Copy link
Contributor

@rben01 rben01 commented Dec 3, 2024

Added:

  • pi
  • atan2
  • deg2rad, rad2deg
  • hypot
  • log2, log10

Added:
* pi
* atan2
* deg2rad, rad2deg
* hypot
* log2, log10
Copy link

google-cla bot commented Dec 3, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rben01
Copy link
Contributor Author

rben01 commented Dec 3, 2024

Closes #1118 and #1186

@johnbartholomew johnbartholomew marked this pull request as draft January 18, 2025 16:27
@johnbartholomew johnbartholomew marked this pull request as ready for review January 18, 2025 16:27
@johnbartholomew johnbartholomew merged commit 4487bfb into google:master Jan 18, 2025
6 checks passed
johnbartholomew added a commit to johnbartholomew/go-jsonnet that referenced this pull request Jan 18, 2025
This includes the stdlib additions in
google/jsonnet#1187

Also updates golden files for go-jsonnet tests; the changes
to the goldens are mostly changes to error locations from
the standard library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants