Initialize Jsonnet::vm_ field to nullptr #1144
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Jsonnet class constructor doesn't set up the VM; this is deferred until the user calls init(). However it's important for the vm_ field to itself be initialised to a known value. The Jsonnet destructor will attempt to destroy the VM only if the vm_ field is not null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Jsonnetclass constructor doesn't set up the VM; this is deferred until the user callsinit(). However it's important for thevm_field to itself be initialised to a known value. TheJsonnetdestructor will attempt to destroy the VM only if thevm_field is not null.