Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add atan2 to std #1118

Closed
sciconf opened this issue Nov 26, 2023 · 2 comments
Closed

add atan2 to std #1118

sciconf opened this issue Nov 26, 2023 · 2 comments

Comments

@sciconf
Copy link

sciconf commented Nov 26, 2023

It would be great to add atan2 to std. atan2 is super useful for converting from rectangular to polar coordinates.

It can be written in jsonnet itself, but, it's so simple and ubiquitous that it just seems better to add it with all the other trig functions in std. Thanks!
@sciconf sciconf mentioned this issue Nov 26, 2023
Closed
@sparkprime
Copy link
Contributor

This can go in std.jsonnet presumably?

CertainLach added a commit to CertainLach/jrsonnet that referenced this issue Nov 30, 2023
@CertainLach
feat: add std.atan2
a5b2c19 
Fixes: #141
Fixes: google/jsonnet#1118
CertainLach added a commit to CertainLach/jsonnet that referenced this issue Nov 30, 2023
@CertainLach
feat: add std.atan2
a8d47a8 
Fixes: google#1118
CertainLach added a commit to CertainLach/jsonnet that referenced this issue Nov 30, 2023
@CertainLach
feat: add std.atan2
a22be2f 
Fixes: google#1118
@CertainLach CertainLach mentioned this issue Nov 30, 2023
Closed
@rben01 rben01 mentioned this issue Dec 3, 2024
Merged
@johnbartholomew
Copy link
Collaborator

Implemented by #1187 - this should be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add std.atan2 CertainLach/jsonnet
3 participants
@johnbartholomew @sparkprime @sciconf