Error out if the language version of the target package is too low #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Much be at least 3.0 since we generate code with case statements Fixes #1462
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
kevmoo
commented
Jan 11, 2025
| final proc = await TestProcess.start( | ||
| 'dart', | ||
| Platform.resolvedExecutable, |
There was a problem hiding this comment.
Tests should run on windows now!
kevmoo
commented
Jan 11, 2025
| final output = lines.toString(); | ||
| final expectedWarningCount = message == null ? 0 : 1; | ||
| final warningCount = '[WARNING]'.allMatches(output).length; | ||
| expect( |
There was a problem hiding this comment.
Make sure there are only the warnings we are expecting and no more!
kevmoo
commented
Jan 11, 2025
| @@ -37,21 +41,36 @@ Future<void> _validatePubspec(bool production, BuildStep buildStep) async { | |||
| return; | |||
| } | |||
|
|
|||
| Future<Pubspec> readPubspec(AssetId asset) async { | |||
There was a problem hiding this comment.
No clue why I had an inline function called once. Ditched it.
kevmoo
commented
Jan 11, 2025
| final string = await buildStep.readAsString(pubspecAssetId); | ||
| final pubspec = Pubspec.parse(string, sourceUrl: pubspecAssetId.uri); | ||
|
|
||
| if (_checkAnnotationConstraint(pubspec, !production) |
There was a problem hiding this comment.
Seemed the cleanest way to call the function and "do the thing" if the result is not null.
natebosch
approved these changes
Jan 13, 2025
Co-authored-by: Nate Bosch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Must be at least 3.0 since we generate code with case statements
Fixes #1462