Fix empty the end of the tag <form> #397

lifenjoiner · 2017-10-08T10:10:16Z

Fix for issue #350. Shall we?

'An end tag whose tag name is "form"' section at: https://html.spec.whatwg.org/multipage/parsing.html#parsing-main-inbody implicitly_close_tags does the removing work already

googlebot · 2017-10-08T10:10:18Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

lifenjoiner · 2017-10-08T10:17:07Z

I signed it!

lifenjoiner · 2017-10-10T10:41:48Z

Travis CI build failed on it's own configuration.

craigbarnes · 2017-11-11T08:18:41Z

This patch causes a tree construction test to fail:

============================================================================                                   
test/tree-construction/tests6.dat:12: Test 2 failed                                                            
============================================================================                                   
                                                                                                               
Input:                                                                                                         
<!doctype html><form><div></form><div>                                                                         
                                                                                                               
Expected:                                                                                                      
| <!DOCTYPE html>                                                                                              
| <html>                                                                                                       
|   <head>                                                                                                     
|   <body>                                                                                                     
|     <form>                                                                                                   
|       <div>                                                                                                  
|         <div>                                                                                                
                                                                                                               
Received:                                                                                                      
| <!DOCTYPE html>                                                                                              
| <html>                                                                                                       
|   <head>                                                                                                     
|   <body>                                                                                                     
|     <form>
|       <div>
|     <div>

The patch in PR #372 works though.

lifenjoiner · 2017-11-12T01:51:53Z

Thanks for your reply! @craigbarnes
You are right. It works on daily well formed HTML files, but not the quirk formed. I didn't pull the submodules recursively ...

Retrieve <form> element

b27934b

'An end tag whose tag name is "form"' section at: https://html.spec.whatwg.org/multipage/parsing.html#parsing-main-inbody implicitly_close_tags does the removing work already

lifenjoiner closed this Nov 12, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix empty the end of the tag <form> #397

Fix empty the end of the tag <form> #397

lifenjoiner commented Oct 8, 2017

googlebot commented Oct 8, 2017

lifenjoiner commented Oct 8, 2017

lifenjoiner commented Oct 10, 2017

craigbarnes commented Nov 11, 2017 •

edited

Loading

lifenjoiner commented Nov 12, 2017

Fix empty the end of the tag <form> #397

Fix empty the end of the tag <form> #397

Conversation

lifenjoiner commented Oct 8, 2017

googlebot commented Oct 8, 2017

lifenjoiner commented Oct 8, 2017

lifenjoiner commented Oct 10, 2017

craigbarnes commented Nov 11, 2017 • edited Loading

lifenjoiner commented Nov 12, 2017

craigbarnes commented Nov 11, 2017 •

edited

Loading