Update unit tests to support Go 1.22 http.ServerMux changes #3412
Conversation
|
Note that the PR that solves #3409 (hopefully this one) will also revert the changes to:
made here: https://github.com/google/go-github/pull/3410/files |
gmlewis
changed the title
| @@ -916,6 +916,9 @@ func TestRepositoriesService_ListBranches(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| // Test removed: "feat/branch-50%" registered with the same pattern as "b". | |||
| // Reason: The new logic in ServeMux requires unique patterns. | |||
| // This test is no longer necessary as the pattern is already covered by another test. | |||
There was a problem hiding this comment.
As you proceed, note that the feat/branch-50% case is important because of:
#2948
So if it is the same pattern as "b", then the "b" case should be removed and the more challenging case should remain.
Although I'm a bit confused by the comment because it says "Test removed" but I'm not seeing its removal (which is actually good... so maybe the comment just needs updating?).
Could you clarify why we should revert the changes in README.md and script/test.sh from PR #3410? Understanding the reasoning will help ensure this PR aligns with the project's goals. |
From the description of #3409:
Reverting the changes to |
I'm not understanding, I leave the tests as before and revert the changes to #3409? |
No. You remove these two lines from # TODO(gmlewis): Remove this when #3409 is resolved.
export GODEBUG=httpmuxgo121=1and you make sure all unit tests pass without these two lines using Go 1.23.4. Then you remove lines 18-29 from README.md. That's it. |
I understand, it's okay. Thank you for your explanation |
|
Hi, sorry for the delay, while I'm solving errors, errors continue to appear xD |
No worries, @DiegoDev2 - there's no rush. |
very good, the pr is not ready yet, but I would like you to see the small changes I made, there is a particular test that gives me problems but I am working on solving it. @gmlewis
This PR is directed to the problem #3409