-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix copilot API payload #3034
Fix copilot API payload #3034
Conversation
Investigating why tests are failing... |
Oh, I see... the unit tests need updating. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @zetaab !
Let's please keep the struct field names matching the JSON field tag names.
I'm not going to mark this as a Breaking API change since this was just introduced within this major version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @zetaab !
LGTM.
Merging after tests pass.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3034 +/- ##
=======================================
Coverage 97.71% 97.71%
=======================================
Files 152 152
Lines 13241 13241
=======================================
Hits 12939 12939
Misses 213 213
Partials 89 89 ☔ View full report in Codecov by Sentry. |
small fix to #2973
cc @gmlewis @o-sama