Add support for exegesis annotator in BHive conversion script #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds support for using the exegesis annotator in the BHive conversion script.
ondrasej
requested changes
Feb 2, 2024
mtrofin
reviewed
Feb 2, 2024
|
|
||
| auto llvm_state_or_error = llvm::exegesis::LLVMState::Create("", "native"); | ||
| if (!llvm_state_or_error) { | ||
| std::cerr << "Failed to create LLVMState\n"; |
There was a problem hiding this comment.
We could, but the rest of the file uses standard library output, so I'm staying consistent with that for now. Not sure what would be preferred though. I think within Google, everything would use absl::log, and LLVM has its own output facilities, so this is sort of in no man's land.
I think this one is fine. We're using LLVM from this one, but we don't need tflite, so Bazel build should not be a problem. It would be nice to get rid of Abseil eventually, but it's not necessary in this PR. |
ondrasej
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for using the exegesis annotator in the BHive conversion script.