Change constants in BHive conversion script #39
Conversation
This patch adjusts the constants in the BHive conversion script to the values used within the original BHive paper. Anecdotally, these constants have also seemed to work better than the original ones. In addition, this patch prefixes the memory value with zeroes so that llvm-exegesis is able to assume the correct bit width.
which are the original counter values, the ones in the original paper or the ones before this change? |
| @@ -64,6 +65,14 @@ int main(int argc, char* argv[]) { | |||
| gematria::ConvertHexToString(kInitialRegVal); | |||
| std::string initial_mem_val_str = | |||
| gematria::ConvertHexToString(kInitialMemVal); | |||
| // Prefix the string with zeroes as llvm-exegesis assumes the bit width | |||
There was a problem hiding this comment.
Slightly unrelated, but necessary to make this patch work properly. We're assuming the memory value has a width of 64 bits, but only setting the first x bits. Exegesis determines the width of the value based on how many characters are in the string, so we need to explicitly print out the leading zeros.
The ones before this change. We're switching to the values in the BHive paper here. |
Ack, if you can update the patch description |
This patch adjusts the constants in the BHive conversion script from the default values added in with the script to the values used within the original BHive paper. These constants were experimentally determined within the BHive paper to be high enough to not underflow/access addresses in the first page yet low enough to not access any addresses above the virtual address space ceiling. Anecdotally, these constants have also seemed to work better than the original ones. In addition, this patch prefixes the memory value with zeroes so that llvm-exegesis is able to assume the correct bit width.