Port loss_utils_test to TF2 #279
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
boomanaiden154
added a commit
to boomanaiden154/gematria
that referenced
this pull request
Jan 3, 2025
The loss_utils class does not need any changes to support TF2, so this patch simply migrates all the test cases to use eager execution. This patch does not make the class idiomatically TF2 however. That will be a later patch once everything else has been ported to allow for incrementally improving the code while validating with all the tests. Pull Request: google#279
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loss_utils class does not need any changes to support TF2, so this
patch simply migrates all the test cases to use eager execution. This
patch does not make the class idiomatically TF2 however. That will be a
later patch once everything else has been ported to allow for
incrementally improving the code while validating with all the tests.