Remove DateTimeBasics.copyWith, add DateTimeBasics.addCalendarMonths
#62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an `addCalendarMonths` extension method for `DateTime`. (It probably could be named just `addMonths`, but I chose `addCalendarMonths` to match the `addCalendarDays` extension method.) Like `addCalendarDays`, `addCalendarMonths` will preserve more granular fields when possible. We'll define the result of "adding N months" to mean the normalized `DateTime` with N added to the month value such that the day of the month either is preserved or is the last day of that month, whichever is earlier. (See the examples from the documentation.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
DateTimeBasics.copyWithin favor of Dart 2.19's owncopyWith.Add an
addCalendarMonthsextension method forDateTime. (It probably could be named justaddMonths, but I choseaddCalendarMonthsto match theaddCalendarDaysextension method.)Like
addCalendarDays,addCalendarMonthswill preserve more granular fields when possible. We'll define the result of "adding N months" to mean the normalizedDateTimewith N added to the month value such that the day of the month either is preserved or is the last day of that month, whichever is earlier. (See the examples from the documentation.)