Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct delete[] operator for saved ALPN data. #1180

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

prbprbprb
Copy link
Collaborator

Causes runtime aborts when using tcmalloc and is UB everywhere else.

Could probably tidy this further (e.g. use ScopedBytesRO when saving the ALPN data), but not today.

Causes runtime aborts when using tcmalloc and is UB
everywhere else.

Could probably tidy this further (e.g. use ScopedBytesRO
when saving the ALPN data), but not today.
Copy link
Contributor

@davidben davidben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd this isn't just, I dunno, std::vector<uint8_t>. Ah well. :-)

@prbprbprb
Copy link
Collaborator Author

Odd this isn't just, I dunno, std::vector<uint8_t>. Ah well. :-)

Yeah, I think the whole class could use some love, but it can probably wait until we can finally remove the ConscryptFileDescriptorSocket parts. Meanwhile this at least gets me past the crashing bugs :)

@prbprbprb prbprbprb merged commit 6ec6e25 into google:master Nov 3, 2023
14 of 15 checks passed
@prbprbprb prbprbprb deleted the appdata branch November 3, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants